Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modernization for SiPixelClusterProducer #25811

Merged
merged 5 commits into from Feb 5, 2019

Conversation

makortel
Copy link
Contributor

This PR contains following changes of which some help the Patatrack GPU work

  • Use unique_ptr
  • Throw an exception for incorrect configuration
  • Implement fillDescriptions()
  • Use edm::EDPutTokenT

Tested in CMSSW_10_5_0_pre1, no changes expected.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25811/8247

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers
RecoLocalTracker/SiPixelClusterizer

@perrotta, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @dkotlins, @rovere, @gpetruc, @mmusich, @threus, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32921/console Started: 2019/01/31 06:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25811/32921/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32962/console Started: 2019/02/01 19:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Pull request #25811 was updated. @perrotta, @cmsbuild, @fwyzard, @tocheng, @Martin-Grunewald, @franzoni, @slava77, @pohsun can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25811/32962/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@pohsun
Copy link

pohsun commented Feb 2, 2019

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 5, 2019

+1

  • Kind of technical pull request which implements what anticipated in the PR description
  • Jenkins tests pass and show no differences

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 5, 2019

+1

@cmsbuild cmsbuild merged commit 8957186 into cms-sw:master Feb 5, 2019
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants