Modernize dictionary generation in FastSimDataFormats

[Dr15Jones]

-removed use of the struct dictionary

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25828/8271

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FastSimDataFormats/CTPPSFastSim
FastSimDataFormats/External
FastSimDataFormats/NuclearInteractions
FastSimDataFormats/PileUpEvents

The following packages do not have a category, yet:

FastSimDataFormats/CTPPSFastSim
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @lveldere, @civanch, @ssekmen, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32943/console Started: 2019/01/31 22:03

[cmsbuild]

+1
Tested at: cc21c03
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25828/32943/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25828/32943/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[ssekmen]

+1

[fabiocos]

@Dr15Jones this update follows that of #25830 and #25831. While I understand it is safe in itself for this CMSSW version, I would like to ensure that it does not pose any issue in the case it is further extended to classes that will be used in the UL production as input for an HLT processing to be performed in older CMSSW versions, as discussed in the past

[Dr15Jones]

While I understand it is safe in itself for this CMSSW version, I would like to ensure that it does not pose any issue in the case it is further extended to classes that will be used in the UL production as input for an HLT processing to be performed in older CMSSW versions, as discussed in the past

This change actually has nothing to do with CMSSW changes. We could have done this same change when we switched from ROOT 5 to ROOT 6.0 but we just didn't realize it at the time. It now appears that this "fossil" is exciting a bug in the CXXMODULES build so it is a good time to get rid of item. With or without the dictionary dummy class, ROOT is supposed to generate the exact same class dictionary code. As far as I can tell, that appears to be true.

[fabiocos]

@Dr15Jones by CMSSW version I was meaning the whole environment including externals versions.
CMSSW_8_0_X is already using ROOT6, so it should be ok.

[fabiocos]

the FastSimDataFormats/CTPPSFastSim was missing in cms-bot, I am adding a PR to fix this

[fabiocos]

+1

[fabiocos]

merge