Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed struct dictionary from classes.h in TBDataFormats #25831

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Dr15Jones
Copy link
Contributor

ROOT no longer requires forcing the instantiation of templates
in the .h file. The declaration in classes_def.xml is sufficient.

ROOT no longer requires forcing the instantiation of templates
in the .h file. The declaration in classes_def.xml is sufficient.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25831/8275

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

TBDataFormats/EcalTBObjects
TBDataFormats/HcalTBObjects

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32946/console Started: 2019/01/31 23:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25831/32946/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2019

+1

the test is not running ECAL TB, but all technical tests do not show any problem

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2019

merge

@Dr15Jones Dr15Jones deleted the removeDictionaryTBDataFormats branch February 4, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants