Use unique_ptr constructor for PluginFactory plugins in AttachSD

[makortel]

This PR is preparatory work to change the PluginFactory to return a std::unique_ptr. On the same go I also changed the management of SensitiveDetector object from raw pointer to unique_ptr (within AttachSD::create(), likely the return type could be changed to use unique_ptr as well but I'd leave that out from this PR).

Tested in CMSSW_10_5_X_2019-01-23-1100, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25832/8278

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

SimG4Core/SensitiveDetector

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32950/console Started: 2019/02/01 04:26

[cmsbuild]

+1
Tested at: 98ad817
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25832/32950/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25832/32950/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1
concerning change the return type I am not sure: SensitiveDetector is a Geant4 object, it should follow G4 interface, deletion is G4 responsibility (good or bad it is).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

@civanch Is the second commit 98ad817 actually wrong then?

[civanch]

@makortel , may be I am wrong, but it seems to be fine - you release std::unique_ptr and put it into the std::vector of pointers, I understand this as you give this object to G4.

[fabiocos]

+1

@civanch @makortel in any case in this PR the return type is untouched