Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis - removing '//' from header include. #25855

Merged
merged 1 commit into from Feb 6, 2019

Conversation

gudrutis
Copy link
Contributor

@gudrutis gudrutis commented Feb 4, 2019

The // is not needed in the include path and it gives problems for LXR indexing the file.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25855/8314

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

A new Pull Request was created by @gudrutis (Zygimantas Matonis) for master.

It involves the following packages:

PhysicsTools/TagAndProbe

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gudrutis
Copy link
Contributor Author

gudrutis commented Feb 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32991/console Started: 2019/02/04 16:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25855/32991/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 5, 2019

@santocch this looks trivial could you please check and sign it in case?

@santocch
Copy link

santocch commented Feb 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2019

+1

@cmsbuild cmsbuild merged commit a91c6fa into cms-sw:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants