Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating relvals strings #25872

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

prebello
Copy link
Contributor

@prebello prebello commented Feb 6, 2019

this PR is made to update FullSim and FastSim strings in 10-5-X cycle

FYI @fabiocos

@prebello
Copy link
Contributor Author

prebello commented Feb 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The code-checks are being triggered in jenkins.

@prebello
Copy link
Contributor Author

prebello commented Feb 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25872/8333

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33018/console Started: 2019/02/06 12:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

A new Pull Request was created by @prebello (Patricia Rebello Teles) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison job queued.

@prebello
Copy link
Contributor Author

prebello commented Feb 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25872/33018/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7394 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 28164
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3069074
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.868 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): 1.188 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.128 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

please test workflow 25400.18,250400.18

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33028/console Started: 2019/02/07 10:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25872/33028/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25872/250400.18_ZEE_13+FS_ZEE_13_PRMXUP18_PU50+HARVESTUP18FS+MINIAODMCUP18FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25872/25400.18_ZEE_13+FS_ZEE_13_UP18_PU50+HARVESTUP18FS+MINIAODMCUP18FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7393 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 28164
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3069074
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.868 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 25202.0 ): -0.128 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 1.188 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

@kpedro88 any comment? Otherwise I would like to merge it to solve the issue of the crashing tests

@fabiocos
Copy link
Contributor

fabiocos commented Feb 8, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Feb 8, 2019

merge

@kpedro88 the updated relvals are not upgrade specific, I move forward to see whether all issues are resolved as expected, in case please sign it for reference or comment for possible further updates

@cmsbuild cmsbuild merged commit f7ce74f into cms-sw:master Feb 8, 2019
@kpedro88
Copy link
Contributor

kpedro88 commented Feb 8, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants