Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CsHepFilter #25895

Merged
merged 1 commit into from Feb 12, 2019
Merged

Conversation

Andrej-CMS
Copy link
Contributor

this is the backport of #25479

@panwarlsweet do you need backports to other CMSSW versions?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

A new Pull Request was created by @Andrej-CMS for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/Core

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33059/console Started: 2019/02/08 18:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

@panwarlsweet
Copy link
Contributor

@andrej, yes, for Fall 17 sample I need it for CMSSW_9_3_X and for Fall18 sample, I need it for CMSSW_10_2_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25895/33059/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 2882
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 679279
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

backport of #25479

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d08e99 into cms-sw:CMSSW_7_1_X Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants