New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused RPCBxTest #25940
Removed unused RPCBxTest #25940
Conversation
-The code was causing a clang warning. -Instances of RPCBxTest could not be instantiated since they no longer overwrite abstract virtual functions of th base class. -Moving to the new base class interface is not possible since the base class no longer supports functionality used by RPCBxTest.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25940/8433
|
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/RPCMonitorClient @cmsbuild, @kmaeshima, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
-The code was causing a clang warning.
-Instances of RPCBxTest could not be instantiated since they no
longer overwrite abstract virtual functions of th base class.
-Moving to the new base class interface is not possible since
the base class no longer supports functionality used by RPCBxTest.