Create a prefire veto bit using trigger rules

[apana]

Add trigger bit to emulated GlobalExtBlk to indicate event could not have been caused by prefiring of the trigger. GlobalExtBlk contains the technical trigger bit information. Since these bits are not properly emulated anyway it is save to add the bit here.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25973/8478

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @apana (Leonard Apanasvich) for master.

It involves the following packages:

Configuration/StandardSequences
L1Trigger/L1TGlobal

@cmsbuild, @nsmith-, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33199/console Started: 2019/02/20 08:23

[cmsbuild]

+1
Tested at: e0d51ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25973/33199/summary.html

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25973/33199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+operations

the update of the StandardSequences looks coherent with the purpose of the PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[fabiocos]

@apana @rekovic this PR looks to introduce a circular dependency in the schedule, that causes two unit tests to fail, see https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc700/www/fri/10.6-fri-23/CMSSW_10_6_X_2019-02-22-2300?utests

----- Begin Fatal Exception 23-Feb-2019 12:42:16 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
[0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found:
simGtExtFakeStage2Digis consumes tcdsDigis, tcdsDigis consumes rawDataCollector, rawDataCollector after castorRawData [p
ath digi2raw_step], castorRawData after rpcpacker [path digi2raw_step], rpcpacker after dtpacker [path digi2raw_step], d
tpacker after cscpacker [path digi2raw_step], cscpacker after hcalRawDataVME [path digi2raw_step], hcalRawDataVME after
esDigiToRaw [path digi2raw_step], esDigiToRaw after ecalPacker [path digi2raw_step], ecalPacker after SiStripDigiToRaw [
path digi2raw_step], SiStripDigiToRaw after siPixelRawData [path digi2raw_step], siPixelRawData after gtStage2Raw [path
digi2raw_step], gtStage2Raw consumes simGtExtFakeStage2Digis
Running in the threaded framework would lead to indeterminate results.
Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 23-Feb-2019 12:43:32 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
[0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found:
rawDataCollector consumes gtStage2Raw, gtStage2Raw consumes simGtExtFakeStage2Digis, simGtExtFakeStage2Digis consumes tc
dsDigis, tcdsDigis consumes rawDataCollector
Running in the threaded framework would lead to indeterminate results.
Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------