Move duplicate getCtfTrackRef function to its own file

[guitargeek]

Just some reorganization of duplicate code in RecoEgamma, which also goes in the direction of slimming down a bit GsfElectronAlgo aka. "the electron god class".

Are there any convention related to names of files holding free functions like this? And do you maybe share my sentiment that the function should be maybe given a more clear name like getClosestCtfToGsf?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25976/8481

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33192/console Started: 2019/02/19 18:18

[cmsbuild]

+1
Tested at: 017d3d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25976/33192/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25976/33192/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[guitargeek]

Hi @perrotta, with #25977 being merged soon I will have to do a rebase here. Do you have any suggestion about e.g. the file name so I can do the rebase and implement comments in one go? Thanks!

[perrotta]

About the name of the file: you could do something similar as, e.g., EgAmbiguityTools in the same package: GsfElectronTools (?) with a namespace which includes the functions in it (only this one, by now).
About the name of the function, since it is only addressed in a couple of places in cmssw, I think you can rename it in some more appropriate way if you think so.

[perrotta]

Include guard should include the full path

[guitargeek]

Ok! Thanks for giving your opinion.

[perrotta]

please test
(hoping that the issue described in #26002 can be solved now)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33266/console Started: 2019/02/25 16:01

[cmsbuild]

+1
Tested at: d806103
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25976/33266/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25976/33266/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• It just moves a utility function into a dedicated file, so that it can be called from the different classes without code duplication
• No change expected in outputs: jenkins tests pass and show no changes
• (The same could have been obtained by using directly the same function as defined in GsfElectronCoreBaseProducer: this PR goes in the direction of separating those "utility functions" from the class code, which gets therefore "slimmed" as such)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1