Removed unneeded uses of unique_ptr from GsfElectronAlgo

[Dr15Jones]

In addition to being a code cleanup, this avoids an apparent compiler bug in clang 7 where default constructors are required but missing.

[Dr15Jones]

This fixes the linking problem seen in the CLANG IBs

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25977/8482

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33190/console Started: 2019/02/19 17:29

[guitargeek]

Thank you, I missed that in my last PR.

[guitargeek]

Are the remaining unique pointers also causing these clang errors by the way? They are a bit more involving to get rid of.

[Dr15Jones]

@guitargeek

Are the remaining unique pointers also causing these clang errors by the way? They are a bit more involving to get rid of.

Only 1 caused a clang problem. The ones I didn't change seemed to be a reasonable use of std::unique_ptr.

[cmsbuild]

+1
Tested at: c3e7ce1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25977/33190/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7de928e
50806c6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25977/33190/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25977/33190/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25977/33190/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

@Dr15Jones , for my own education:

• You say that only 1 caused a clang problem: is it GeneralData, correct?
• If so, why did you remove the unique_ptr also for EventSetupData?
• (Saying it differently) why didn't you remove it also for EventData and ElectronData? Only because they are a bit more involved to get rid of it?

[Dr15Jones]

@perrotta

(Saying it differently) why didn't you remove it also for EventData and ElectronData?

GeneralData and EventSetupData were being 'new'ed in the constructor and 'delete'd in the destructor thereby having a lifetime equal to the parent class. That is exactly the same lifetime as member data.

EventData and ElectronData are 'new'ed and 'delete'd each event.

[perrotta]

Right. Thank you Chris! Chris Jones <notifications@github.com> ha scritto:

…

@perrotta > (Saying it differently) why didn't you remove it also for EventData > and ElectronData? GeneralData and EventSetupData were being 'new'ed in the constructor and 'delete'd in the destructor thereby having a lifetime equal to the parent class. That is exactly the same lifetime as member data. EventData and ElectronData are 'new'ed and 'delete'd each event. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25977 (comment)

[Dr15Jones]

ping

[Dr15Jones]

This change is needed to fix the broken builds on CLANG

[perrotta]

+1

• The fix is technical and integrate what proposed in the description (and thank you Chris for the further explanation)
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1