B parking Skimming code update #25984
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25984/8492
|
|
A new Pull Request was created by @gkaratha for master. It involves the following packages: Configuration/Skimming @cmsbuild, @zhenhu, @prebello, @pgunnell can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
Dear all, In order to be in syncc with the latest developments in low pT electrons, I changed how the BDT value is read by the code (ie first go from electron -> gsfTrack -> read value). The BDT values are the same and the change is technical only. The WP gives the same performance (Rate 5.35%) when running on the same dataset. Thanks. Best, |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25984/8511
|
|
-1 Tested at: 79cb215 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 4 hours. |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
Dear all, Checking the logs I see that the reason of failure is due to this: Module: MixingModule:mix (crashed). Naively i would think that skimming does not actually affects mixing module. The reason is that probably the skimming will run after generation (and mixing) is finished. The other argument is that essentially the code is the same with previous time with the difference of using low pT e as input. Can we try to test without the skim or with the previous skim? I will also try to reproduce it locally. Many thanks. Best, |
|
the crash looks unrelated to this PR |
|
please test workflow 136.898 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 79cb215 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 4 hours. |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
+1 the test failure is unrelated to this PR (it originally succeeded), the test specific to the B parking skim passes smoothly |
|
merge |
|
@fabiocos |
|
@bainbrid this is for 10_6_X, now, and I understand you are interested into a 10_2_X backport. Could you please clarify why 10_5_X would be eventually interesting for this PR? |
|
It's not necessary, we can just go with 10_6_X. |
Dear all,
Since there was a conflicts due to merging of the BParking skimming and our need to move to low pT e both in the analysis and for skimming, I opened a new PR without conflicts. Proposed by @kfjack . If everyone agrees we can close the previous PR and continue the discussion here? Adding @bainbrid and @mverzett . Thanks.
Best regards,
George Karathanasis