New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New working point for B parking skim #26015
New working point for B parking skim #26015
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26015/8536
|
A new Pull Request was created by @gkaratha for master. It involves the following packages: Configuration/Skimming @cmsbuild, @zhenhu, @prebello, @pgunnell can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
hi @kfjack could you please take a look ? |
Hi @prebello I think this change is totally okay (only changed one single threshold)! Many thanks. |
@gkaratha sorry to be pedantic, but please update the title to something a bit more explicative (New working point for B parking skim ?) |
please test workflow 136.898 |
The tests are being triggered in jenkins. |
Dear @fabiocos , You are right it was an awful name. Thanks for the suggestion. Best, |
Comparison job queued. |
+1 Thank you @kfjack |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@gkaratha if you have any plot showing the improvement please attach it to this PR |
+1 |
Dear @fabiocos , Yes, gladly. I have attached it. Thanks. Best regards, |
Dear all,
Please consider this new PR. Its a better WP for B parking skimming. No code has been changed. Only the WP. The new WP has 6.5% rate while keeping a bit more than 29% in efficiency. Thanks.
Best regards,
George Karathanasis