Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New working point for B parking skim #26015

Merged
merged 1 commit into from Feb 26, 2019

Conversation

gkaratha
Copy link
Contributor

Dear all,

Please consider this new PR. Its a better WP for B parking skimming. No code has been changed. Only the WP. The new WP has 6.5% rate while keeping a bit more than 29% in efficiency. Thanks.

Best regards,
George Karathanasis

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@gkaratha
Copy link
Contributor Author

@bainbrid @mverzett

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26015/8536

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @zhenhu, @prebello, @pgunnell can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

hi @kfjack could you please take a look ?
thank you

@kfjack
Copy link
Contributor

kfjack commented Feb 26, 2019

Hi @prebello I think this change is totally okay (only changed one single threshold)! Many thanks.

@fabiocos
Copy link
Contributor

@gkaratha sorry to be pedantic, but please update the title to something a bit more explicative (New working point for B parking skim ?)

@fabiocos
Copy link
Contributor

please test workflow 136.898

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33283/console Started: 2019/02/26 10:22

@gkaratha gkaratha changed the title change WP New working point for B parking skim Feb 26, 2019
@gkaratha
Copy link
Contributor Author

Dear @fabiocos ,

You are right it was an awful name. Thanks for the suggestion.

Best,
George

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1

Thank you @kfjack

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26015/33283/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26015/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Prompt+HARVEST2018

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3098286
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3098088
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@gkaratha if you have any plot showing the improvement please attach it to this PR

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f9e6f12 into cms-sw:master Feb 26, 2019
@gkaratha
Copy link
Contributor Author

Dear @fabiocos ,

Yes, gladly. I have attached it. Thanks.

Best regards,
George

wp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants