Store HCAL RecHits for volumes crossed by muon trajectory

[drkovalskyi]

Added an options to store HBHERecHits that were crossed by muon. It's needed for muon identification studies and commissioning of the HB new readout. There should be no impact on CPU time, since the information is already extracted. We just need to make sure it won't cause significant increase in the output. If it does we will use it only in special requests. Quick check on Run2018 data shows ~1% increase of MiniAOD, which should be Ok.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26021/8543

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @drkovalskyi for master.

It involves the following packages:

DataFormats/MuonReco
RecoMuon/MuonIdentification

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @rovere, @echapon, @calderona, @HuguesBrun, @jhgoh, @battibass, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33307/console Started: 2019/02/26 22:19

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26021/8545

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #26021 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

[drkovalskyi]

FYI @mariadalfonso

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26021/8659

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #26021 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33446/console Started: 2019/03/06 19:27

[cmsbuild]

+1
Tested at: d34def9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26021/33446/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26021/33446/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114826
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114628
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26021 d34def9

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences (the newly saved data are not monitored)
• local tests with 200 evts from 136.863 (DoubleMuon 2018B) and 1K evts from 10807 (pt10 muon gun) show roughly expected behavior
  • the miniAOD size increased by about 50 bytes/muon ({~4 hits/muon}x {4 floats + detId per hit}x compression).
  • it's perhaps worth to reduce precision on the stored values at the muon slimming level; but the total seems manageable anyways.

In the pt10 muon gun sample in 2018 setup without PU (black is with this PR):

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1