FWCore/ParameterSet changes for python3 compatibility

[davidlange6]

Unit tests in FWCore/PyDevParameterSet now run correctly if python3 is used (in addition to already working with python2)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26025/8551

• This PR adds an extra 72KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33314/console Started: 2019/02/27 10:55

[cmsbuild]

-1

Tested at: 09e01b1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26025/33314/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS
---> test testConditionDatabase_2 had ERRORS

[cmsbuild]

Comparison job queued.

[Dr15Jones]

The unit test failure is NOT from this pull request since it is happening in the IB.

[davidlange6]

i think its still my fault...

…

On Feb 27, 2019, at 2:29 PM, Chris Jones ***@***.***> wrote: The unit test failure is NOT from this pull request since it is happening in the IB. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fabiocos]

@Dr15Jones @davidlange6 indeed the failure https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_10_6_X_2019-02-26-2300/unitTestLogs/FWCore/ParameterSet#/59-59 seems due to a missing . in Modules.py when there are import from Types, but I already verified this morning that just fixing it triggers another problem

[Dr15Jones]

#26026 fixes the unit test problem

[fabiocos]

please test with #26026

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33318/console Started: 2019/02/27 15:02

[fabiocos]

please abort

[cmsbuild]

Jenkins tests are aborted.

[fabiocos]

please test with #26026

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33329/console Started: 2019/02/27 20:14

[cmsbuild]

+1
Tested at: 09e01b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26025/33329/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
beada71
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26025/33329/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26025/33329/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26025/33329/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[davidlange6]

hi @Dr15Jones - did this PR need more attention?

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1