Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports all needs for runTheMatrix to 80X #26039

Merged
merged 4 commits into from Mar 11, 2019

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 1, 2019

Backport all needs for MatrixInjector/runTheMatrix upto #19681 (CMSSW_9_3_0_pre2) to fix the injection to reqmgr2

This is a proposal to fix https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/4412.html

Test of injection success,
https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/4412.html
@prebello

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_8_0_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

135.4, #Run 2 Zee ttbar
10042.0, #2017 ZMM
10024.0, #2017 ttbar
10824.0, #2018 ttbar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows beyond 2017 do not exist in 80X, remove this line and the following two lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, done. Please check.

wmsplit['DigiFullPU']=1
wmsplit['RecoFullPU']=1
wmsplit['RECOHID11']=1
wmsplit['DigiFullPU_2023D17PU']=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably these 2023-specific steps can be removed too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, done. Please check.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

Pull request #26039 was updated. @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

Pull request #26039 was updated. @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33384/console Started: 2019/03/04 13:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26039/33384/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 14
  • DQMHistoTests: Total histograms compared: 977277
  • DQMHistoTests: Total failures: 832
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 976347
  • DQMHistoTests: Total skipped: 98
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -13 KiB( 13 files compared)
  • Checked 58 log files, 7 edm output root files, 14 DQM output files

@@ -132,6 +139,12 @@ def runSelected(opt):
dest='step1Only',
default=False
)
parser.add_option('--maxSteps',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srimanob it looks to me there is no code to consume this option in 8_0_X

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocos I removed it as suggestion.

1000, #data+prompt
1001, #data+express
136.731, #2016B Photon data
136.7611, #2016E JetHT reMINIAOD from 80X legacy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this PR is now, this does not work, not sure whether we really need for the purpose of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocos removed

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2019

Pull request #26039 was updated. @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33484/console Started: 2019/03/08 16:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26039/33484/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 14
  • DQMHistoTests: Total histograms compared: 977277
  • DQMHistoTests: Total failures: 839
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 976340
  • DQMHistoTests: Total skipped: 98
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -13 KiB( 13 files compared)
  • Checked 58 log files, 7 edm output root files, 14 DQM output files

@fabiocos
Copy link
Contributor

@kpedro88 @prebello @zhenhu any other comment?

@prebello
Copy link
Contributor

none from my side. Thank you.

@prebello
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0170170 into cms-sw:CMSSW_8_0_X Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants