New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports all needs for runTheMatrix to 80X #26039
Conversation
A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_8_0_X. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
135.4, #Run 2 Zee ttbar | ||
10042.0, #2017 ZMM | ||
10024.0, #2017 ttbar | ||
10824.0, #2018 ttbar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflows beyond 2017 do not exist in 80X, remove this line and the following two lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, done. Please check.
wmsplit['DigiFullPU']=1 | ||
wmsplit['RecoFullPU']=1 | ||
wmsplit['RECOHID11']=1 | ||
wmsplit['DigiFullPU_2023D17PU']=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably these 2023-specific steps can be removed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, done. Please check.
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -132,6 +139,12 @@ def runSelected(opt): | |||
dest='step1Only', | |||
default=False | |||
) | |||
parser.add_option('--maxSteps', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srimanob it looks to me there is no code to consume this option in 8_0_X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiocos I removed it as suggestion.
1000, #data+prompt | ||
1001, #data+express | ||
136.731, #2016B Photon data | ||
136.7611, #2016E JetHT reMINIAOD from 80X legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this PR is now, this does not work, not sure whether we really need for the purpose of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiocos removed
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
none from my side. Thank you. |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport all needs for MatrixInjector/runTheMatrix upto #19681 (CMSSW_9_3_0_pre2) to fix the injection to reqmgr2
This is a proposal to fix https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/4412.html
Test of injection success,
https://hypernews.cern.ch/HyperNews/CMS/get/comp-ops/4412.html
@prebello