Added monopole ionisation classes

[civanch]

This is a backport of #26048 - improved simulation of magnetic monopole ionisation. Should not affect mainstream simulation.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_10_2_X.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Added monopole ionisation classes #26048

[civanch]

backport of #26048

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33383/console Started: 2019/03/04 13:45

[cmsbuild]

-1

Tested at: 770e744

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26056/33383/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Creating project symlinks
>> Entering Package SimG4Core/PhysicsLists
>> Entering Package src/BigProducts/Simulation
>> Entering Package src/BigProducts/Simulation
>> Building big plugin tmp/slc6_amd64_gcc700/src/BigProducts/Simulation/pluginSimulation.so
c++: error: objs/slc6_amd64_gcc700/SimG4CorePhysicsLists.obj: No such file or directory
gmake: *** [tmp/slc6_amd64_gcc700/src/BigProducts/Simulation/pluginSimulation.so] Error 1
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built


• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/MonopoleTransportation.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/CMSFTFPNeutronBuilder.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/CMSFTFPProtonBuilder.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/DummyEMPhysics.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/UrbanMscModel93.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/CMSMonopolePhysics.cc:16:21: error: out-of-line definition of 'CMSMonopolePhysics' does not match any declaration in 'CMSMonopolePhysics'
CMSMonopolePhysics::CMSMonopolePhysics(const HepPDT::ParticleDataTable * pdt,
                    ^~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2019-03-04-1100/src/SimG4Core/PhysicsLists/src/CMSMonopolePhysics.cc:114:34: error: no matching constructor for initialization of 'MonopoleTransportation'
        pmanager->AddProcess(new MonopoleTransportation(mpl,verbose),-1,0,0);
                                 ^                      ~~~~~~~~~~~


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #26056 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33399/console Started: 2019/03/04 19:37

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26056/33409/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007400
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007209
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33445/console Started: 2019/03/06 18:07

[cmsbuild]

+1
Tested at: f34fc5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26056/33445/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26056/33445/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007400
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007207
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1