Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport : Update GT for ultra legacy - MC ECAL, GEM eMap #26074

Merged
merged 6 commits into from Mar 8, 2019

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Mar 5, 2019

Backport of PR #26049

Revert the PF calibration as we agree that the new PF calibration will only enter CMSSW_10_6_X release

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

A new Pull Request was created by @tocheng (Tongguang) for CMSSW_10_5_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Mar 5, 2019

@cmsbuild please test workflow 1010, 1001.2, 1040, 140.56, 140.57, 150, 158

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33415/console Started: 2019/03/05 17:27

@tocheng
Copy link
Contributor Author

tocheng commented Mar 5, 2019

@srimanob The PF calibration commit is reverted as we agreed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26074/33415/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26074/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26074/1010.0_TestEnableEcalHCAL2017B+TestEnableEcalHCAL2017B+TIER0EXPTE+ALCAEXPTE+ALCAHARVDTE
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26074/1040.0_RunZeroBias2017F+RunZeroBias2017F+TIER0RAWSIPIXELCAL+ALCASPLITSIPIXELCAL+ALCAHARVDSIPIXELCAL

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8633 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3098286
  • DQMHistoTests: Total failures: 26720
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3071368
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.638 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 25202.0 ): -0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.767 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Mar 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants