Added missing include of memory to Herwig6Instance

[Dr15Jones]

PR description:

This fixes a 'check headers' error.

PR validation:

The code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26101/8674

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/Herwig6Interface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33461/console Started: 2019/03/07 17:55

[cmsbuild]

+1
Tested at: ba12b00
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33461/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8c6b1bc
6959115
570852a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33461/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33461/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33461/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 1
8.0 step 1
158.0 step 1
9.0 step 1
7.3 step 1
25202.0 step 1
1330.0 step 1
1306.0 step 1
10024.0 step 1
101.0 step 1
10042.0 step 1
10224.0 step 1
10824.0 step 1
11624.0 step 1
20034.0 step 1
21234.0 step 1
27434.0 step 1
250202.181 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 6297 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 884430
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 884364
• DQMHistoTests: Total skipped: 66
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 72 log files, 4 edm output root files, 15 DQM output files

[Dr15Jones]

@alberto-sanchez @efeyazgan @perrozzi @qliphy please review. The change was trivial.

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33502/console Started: 2019/03/09 22:48

[fabiocos]

+1

the problems in the DQM test were due to the failing IB

[cmsbuild]

+1
Tested at: ba12b00
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33502/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26101/33502/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files