Removed unused function getfullpathfromfip_ #26134
Conversation
In addition to being unused, the function was returning a pointer to already deleted memory. This was found by the clang static analyzer.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26134/8700
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/ReggeGribovPartonMCInterface @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 trivial |
PR description:
In addition to being unused, the function was returning a pointer to already deleted memory.
This was found by the clang static analyzer.
PR validation:
The code compiles. Using
nmon the resultant library showed that the removed function does not appear as a missing symbol. Doing agit grep getfullpathturned up no hits in CMSSW.