Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[80X] bypassVersionCheck should not apply to DQMRootSource #26149

Merged

Conversation

srimanob
Copy link
Contributor

backport of #26147
This is a bug-fix to not apply bypassVersionCheck to DQM in merge step.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2019

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_8_0_X.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33536/console Started: 2019/03/12 09:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26149/33536/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 1044669
  • DQMHistoTests: Total failures: 927
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1043634
  • DQMHistoTests: Total skipped: 108
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
  • Checked 62 log files, 7 edm output root files, 15 DQM output files

@fabiocos
Copy link
Contributor

+operations

the backport is coherent with the fix in master

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5b9d30b into cms-sw:CMSSW_8_0_X Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants