Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility BP #26172

Merged

Conversation

mrodozov
Copy link
Contributor

Backport of 26083 to 10_3

PR description:

See the title

PR validation:

Compiled the PR with this changes cms-sw/cmsdist#4778 to see if something was missing.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmsdist#4778

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4778
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33575/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for CMSSW_10_3_X.

It involves the following packages:

CaloOnlineTools/HcalOnlineDb
OnlineDB/CSCCondDB
OnlineDB/EcalCondDB
OnlineDB/Oracle
OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26172/33575/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3203312
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3203114
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

backport #26083

@fabiocos
Copy link
Contributor

@ggovi this is the backport needed for the O2O test in MWGR1, could you please check it?

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@ggovi I understand that all O2O tests on your side are successful, please sign it for future reference

@cmsbuild cmsbuild merged commit df78ca9 into cms-sw:CMSSW_10_3_X Mar 15, 2019
@ggovi
Copy link
Contributor

ggovi commented Mar 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants