one::OutputModule now supports transition caches #26196
Conversation
Can now use LuminosityBlockCache and RunCache with one::OutputModule. When used, the module does not cause a synchronization barrier at those transitions.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26196/8793
|
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
hold
pending-signatures
tests-pending
and removed
fully-signed
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
The overwhelming majority of the differences seen in the test were from workflow 11624 which is testing Run3. The commit c24591c, which was added to this pull request for testing, changes Run 3 workflows to read conditions from the DB for the HCAL. Given many (if not all) of the changes originate in the calorimeter, it is likely the changes are only due to c24591c and not due to this pull request. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
unhold |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@Dr15Jones indeed one of the additional merged you picked is supposed to change the Run3 HCAL default conditions |
|
+1 |
PR description:
Can now use LuminosityBlockCache and RunCache with one::OutputModule.
When used, the module does not cause a synchronization barrier at those transitions.
PR validation:
Framework code compiles. All framework related unit tests pass.