Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make L1Trigger/CSCTriggerPrimitives comply with new CMSSW style rules. #26198

Merged
merged 1 commit into from Mar 28, 2019
Merged

Make L1Trigger/CSCTriggerPrimitives comply with new CMSSW style rules. #26198

merged 1 commit into from Mar 28, 2019

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Mar 16, 2019

PR description:

Make L1Trigger/CSCTriggerPrimitives comply with new CMSSW style rules. There should be no change in performance.

PR validation:

Code compiles. Analyzers in plugins/ can again be run with configurations in test/

@tahuang1991

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26198/8796

  • This PR adds an extra 144KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Mar 18, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33638/console Started: 2019/03/18 08:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26198/33638/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Mar 21, 2019

@fabiocos This is a similar PR as #26203

@fabiocos
Copy link
Contributor

@rekovic could you please check? It looks ok to me, essentially a technical move

@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 79f244e into cms-sw:master Mar 28, 2019
@dildick dildick deleted the from-CMSSW_10_6_0_pre2-CSCTriggerPrimitives-CMSSW-style-rules branch April 27, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants