New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] Conditions format update for diamond timing calibration #26207
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26207/8810
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for master. It involves the following packages: CondFormats/CTPPSReadoutObjects @ggovi, @cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Could someone please trigger the tests? Thanks in advance! |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison is ready Comparison Summary:
|
Is there any way we can help proceeding with this PR review? This one is a prerequisite for our forthcoming offline reco patch introducing timing calibration in rechits, much needed prior to UL rereco. |
@forthommel We will review it soon. |
@forthommel Do you have some consideration for not reverting back the argument names of |
``
@pohsun Unfortunately we discovered the overall object footprint would be amended by a change of indexing variables names. As the two subdetectors’ offline codes are sharing these calibrations objects and subsequent indexing variables (but with a slightly different meaning of the indexing parameters) we hence only modified the getters instead. What would you suggest then?
|
+1 @forthommel Thanks for the explanation. Given the meaning in the two subdetectors is different. I thought current treatment is fine enough. |
@ggovi could you please review? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Many thanks, @ggovi! |
# load calibrations from JSON file | ||
process.load('CondFormats.CTPPSReadoutObjects.ppsTimingCalibrationESSource_cfi') | ||
process.ppsTimingCalibrationESSource.calibrationFile = cms.FileInPath('RecoCTPPS/TotemRPLocal/data/timing_offsets_ufsd_2018.dec18.cal.json') | ||
process.ppsTimingCalibrationESSource.calibrationFile = cms.FileInPath('RecoCTPPS/TotemRPLocal/data/timing_calibration_diamond_2018_mar19.ex.json') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forthommel related to your comment cms-data/RecoCTPPS-TotemRPLocal#3 (comment) : I understand this is just a test, but if that file is not merged the test will be broken and in practice useless. Will json files be routinely used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are perfectly right. As it is now, this test is only used as a method to produce the sqlite payload prior to filling the database, therefore only indirectly in production. Same comment for the ESProducer
itself. So no, theses JSON files will not be routinely used in production.
+1 |
PR description:
A new readout mode for timing calibration JSONs is introduced for the
PPSTimingCalibration
ESProducer
. This allows the rechit-level calibration of diamond detectors to be submitted in a follow-up PR (HPTDC time over threshold calibration conditions produced outside this scope).PR validation:
To be tested along with cms-sw/cmsdist#4785, which enables to parse and produce the payload from an external (example) file through the
CondTools/CTPPS/test/ppsTimingCalibrationWriter_cfg.py
utility.Local reco branch maintained in parallel, to be submitted when this PR reaches a more mature state. Validation SW tools part of this follow-up PR.
if this PR is a backport please specify the original PR: N/A
Before submitting your pull requests, make sure you followed this checklist:
cc: @fabferro @jan-kaspar @jjhollar