New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecoParticleFlow/PFProducers - Improve how the PFEGammaFilters and PFMuonAlgo are constructed #26230
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26230/8858
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoParticleFlow/PFProducer @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
} | ||
|
||
auto phHcalProt(const edm::ParameterSet& cfg) { | ||
return cfg.getParameter<edm::ParameterSet>("photon_protectionsForBadHcal"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the repeated calls to this and above optimized away?
If not, perhaps some initialization just has to be moved to the constructor body (or related members grouped into a single initializable member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved it to the constructor body. That means no const
private members in that case, but it doesn't matter in this case I'd say since all member functions are const
.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26230/8997
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Proposes to construct the
PFEGammaFilters
directly from a ParameterSet instead of passing around the individual configuration variables 2 times, which cleans up a bit the code for the PFProducer and the PFAlgo.Also declares all member function of
PFEGammaFilters
asconst
.PR validation:
Local matrix tests pass.