New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD4hep: Merge Development to a Usual Geometry Structure #26231
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26231/8860
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 37db9fb You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found compilation error when building: >> Entering Package DetectorDescription/RecoGeometry Entering library rule at src/DetectorDescription/RecoGeometry/plugins >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/src/DetectorDescription/RecoGeometry/plugins/DTGeometryTest.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/src/DetectorDescription/RecoGeometry/plugins/DTGeometryESProducer.cc In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/src/DetectorDescription/RecoGeometry/plugins/DTGeometryTest.cc:7:0: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/poison/DetectorDescription/DDCMS/interface/MuonGeometryRcd.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^~~~~ /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/src/DetectorDescription/RecoGeometry/plugins/DTGeometryTest.cc: In member function 'virtual void DTGeometryTest::analyze(const edm::Event&, const edm::EventSetup&)': /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-21-2300/src/DetectorDescription/RecoGeometry/plugins/DTGeometryTest.cc:37:19: error: 'MuonGeometryRcd' was not declared in this scope iEventSetup.get().get(m_label, pDD);
I found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Comparison is ready Comparison Summary:
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@fabiocos and @Dr15Jones - are there any reasons not to merge this PR? |
@Dr15Jones @smuzaffar coming back to the geometry move, this was presented at the Core software meeting https://indico.cern.ch/event/809166/contributions/3370866/attachments/1818512/2973256/DD4hep_Directory_Structure.pdf . |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
as from past discussions I understand there is no objection to this scheme, I will move forward with the integration |
+1 |
PR description:
DD4hep based DT reco geometry producer performance is satisfactory: 2.3 s vs 1.2 s
Going ahead with the migration, so keeping all DD4hep code in one package is no longer necessary. Thus, the code has been restructured to facilitate future migration steps by DPGs.
The DT Geometry builder can be taken as an example.
Note for discussion: in order to keep both DD CMS and DD4hep based code in the same package the latter classes are placed as follows:
Alternative suggestions are welcome.
PR validation:
The RelVal tests and the unit tests are run by default
Additional DT Geometry validation plugin is added. To run it:
@fabiocos - please, see the attached histograms. The wire X differences should be investigated. However, it's not a showstopper for this PR to be merged.
@slomeo - FYI.
@smuzaffar - FYI, DetectorDescription/RecoGeometry package is empty now and can be deleted.
if this PR is a backport please specify the original PR:
There is no need to back-port it.
Here is an updated plot using float values in validation: