New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimTrack to muon SimHit matching classes in Muon Validation code #26249
SimTrack to muon SimHit matching classes in Muon Validation code #26249
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26249/8903
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: Validation/MuonHits @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 6921890 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found compilation error when building: >> Package Validation/MuonHits built >> Entering Package Validation/MuonHits Entering library rule at src/Validation/MuonHits/plugins >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/plugins/MuonSimHitsValidAnalyzer.cc In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/plugins/MuonSimHitsValidAnalyzer.cc:1:0: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/poison/Validation/MuonHits/src/MuonSimHitsValidAnalyzer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^~~~~ >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/plugins/SealModule.cc /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/plugins/MuonSimHitsValidAnalyzer.cc:11:17: error: 'edm' is not a namespace-name using namespace edm;
I found compilation error while trying to compile with clang. Command used:
>> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/src/DTSimHitMatcher.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/src/CSCSimHitMatcher.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/src/MuonHitHelper.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/src/GEMSimHitMatcher.cc In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/src/CSCSimHitMatcher.cc:1: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/interface/CSCSimHitMatcher.h:31:42: error: expected ')' std::set detIds(int type MuonHitHelper::CSC_ALL) const; ^ /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-25-2300/src/Validation/MuonHits/interface/CSCSimHitMatcher.h:31:32: note: to match this '(' std::set detIds(int type MuonHitHelper::CSC_ALL) const; ^ |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26249/8918
Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26249/8918/git-diff.patch You can run |
Pull request #26249 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
@drkovalskyi, I'm afraid I'll be busy the next couple of weeks with dissertation defense and such... I did write a summary that should explain how this code is useful (anticipating that I would not have time to compile a full presentation). I may have time in a month or so. |
please test |
The tests are being triggered in jenkins. |
@drkovalskyi is the MUO POG asking to keep this PR on hold? |
No, we are not asking to keep it on hold. We are just no familiar with the work and without a proper presentation I don't expect it to be used in the POG. I hope this can be sorted out later. So let's integrate it. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@andrius-k do you confirm your previous signature? |
+1 |
@mrodozov the bot looks stuck here, I will take this PR as fully signed anyway |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
no idea why it took so long. |
+1 |
PR description:
Which hits in the CMS Muon system originate from a particular simulated muon particle? In the development of new trigger algorithms it is often necessary to discriminate true muon simhits from electron/punch-through/pileup simhits, for example to determine the true efficiency and fake rate.
Tao Huang and I have been developing such validation code since ~2013 and have been using it in our trigger studies for the GEM TDR, Muon Phase-II TP, Muon Upgrade TDR and the L1 Interim TDR. I would now like to provide these expert tools to the larger muon & trigger community.
trackId
between simtrack and simhit.FYI @tahuang1991 @civanch @mdhildreth
PR validation:
The code compiles. The modules are currently not hooked up to existing validation modules, so they should not break any workflows. I also tested the modules by instantiating them in existing DQMEDanalyzers and running on a set of recent high pileup MC samples from the MTD campaign. That showed no obvious issues.