New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-hcx193 Changes to DDHCalBarrelAlgo by removing explicit reference to CLHEP #26272
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26272/8954
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HcalAlgo @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
string rotstr("NULL"); | ||
if (phideg != 0) { | ||
std::string rotstr("NULL"); | ||
if (std::lround(phideg) != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the motivations for removing CLHEP is to eliminate unnecessary conversions from radians to degrees. Please see how this sort of code is handled in DDMuonAngular.cc.
I don't think there is any need to convert angles to degrees except for debug messages.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26272/9264
|
Pull request #26272 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 Comparison differences are assumed to be minor and caused by small changes in generated random numbers. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove explicit reference to CLHEP from DDHCalBarrelAlgo and also making changes to debug statements
PR validation:
Ran the dumpGeometry code with debug switched on in the existing and the new code. The debug prints out all steps within DDHcalBarrelAlgo - all parameters, positions (translation + rotation). A simple diff between the two versions yield no difference:
diff -bw /build/sunanda/CMSSW_10_6_X_2019-03-26-2300/relval/dump1.log dump.log
1c1
< Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 27-Mar-2019 18:52:01.004 CET
if this PR is a backport please specify the original PR:
No back porting is required.