Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx193 Changes to DDHCalBarrelAlgo by removing explicit reference to CLHEP #26272

Merged
merged 3 commits into from Apr 15, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 27, 2019

PR description:

Remove explicit reference to CLHEP from DDHCalBarrelAlgo and also making changes to debug statements

PR validation:

Ran the dumpGeometry code with debug switched on in the existing and the new code. The debug prints out all steps within DDHcalBarrelAlgo - all parameters, positions (translation + rotation). A simple diff between the two versions yield no difference:

diff -bw /build/sunanda/CMSSW_10_6_X_2019-03-26-2300/relval/dump1.log dump.log

1c1
< Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 27-Mar-2019 18:52:01.004 CET

Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 27-Mar-2019 18:51:29.748 CET
656c656
< <<== End of DDHCalBarrelAlgo construction ...


<<== End of DDHCalBarrelAlgo construction

if this PR is a backport please specify the original PR:

No back porting is required.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26272/8954

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33810/console Started: 2019/03/27 19:27

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalAlgo

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26272/33810/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5251 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 5763
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3108869
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

string rotstr("NULL");
if (phideg != 0) {
std::string rotstr("NULL");
if (std::lround(phideg) != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the motivations for removing CLHEP is to eliminate unnecessary conversions from radians to degrees. Please see how this sort of code is handled in DDMuonAngular.cc.
I don't think there is any need to convert angles to degrees except for debug messages.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26272/9264

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #26272 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34190/console Started: 2019/04/13 22:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26272/34190/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8762 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 12256
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3130330
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cvuosalo
Copy link
Contributor

+1

Comparison differences are assumed to be minor and caused by small changes in generated random numbers.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 202279e into cms-sw:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants