Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add necessary changes to handle dump import and fetch novel TrackerDetToDTCELinkCablingMap and DTCELinkId CondFormats #26276

Merged
merged 1 commit into from Apr 3, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 28, 2019

PR description:

As PR #26268 including the novel CondFormats for the Phase-2 Tracker DTC cabling map has been merged, this pull request adds a commit which was left over from original PR #26029, allowing the dumping / DB handling of payloads of type TrackerDetToDTCELinkCablingMap and DTCELinkId

PR validation:

Recipe steps to produce a payload of the new format and dump it:

git cms-addpkg CondTools/SiPhase2Tracker
git cms-addpkg CondFormats/DataRecord
scramv1 b -j 8
cmsenv
cd CondTools/SiPhase2Tracker/test/
cmsRun DTCCablingMapProducer_write.py
conddb --db OuterTrackerDTCCablingMap.db dump e54afaa74e8aff576df16b328b4ef5048004d92f

the last command of this recipe won't work without this PR.

…tToDTCELinkCablingMap and DTCELinkId CondFormats
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26276/8959

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33844/console Started: 2019/03/29 12:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26276/33844/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3134059
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3133861
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Apr 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2019

+1

@cmsbuild cmsbuild merged commit 44b00d2 into cms-sw:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants