Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythia filter to focus on the probe side of B decays (backport) #26300

Merged
merged 1 commit into from Apr 2, 2019

Conversation

gkaratha
Copy link
Contributor

PR description:

Its a dedicated filter to simulate the effect of probe side kinematics for B decays. By probe side we mean that the muons of B should be excluded from the filter, while the filter must be passed by another muon of the event (eg B+->mu1mu2K, B- ->mu3X; we want only the mu3 to be filtered). This filter helps to save valuable events that were going to be wasted by using the "standard" filters.

PR validation:

This is a backport of #26286 . There I have uploaded validation and performance plots. Also that PR passed all the tests.

if this PR is a backport please specify the original PR:

This PR is backport of #26286

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@alberto-sanchez
Copy link
Member

Its is the other way around. This is the implementation and #26286 is the backport

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26300/8991

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33856/console Started: 2019/03/29 17:27

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26300/33856/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3134059
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3133861
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

ping bot?

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+1

validation details provided in the 10_2_X version

@cmsbuild cmsbuild merged commit 4c65ef3 into cms-sw:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants