Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt ETL numbering scheme to new forward volume hierarchy (scenario D41, HGCal v10) #26307

Merged
merged 1 commit into from Apr 2, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Apr 1, 2019

PR description:

Phase 2 scenario D41 (with HGCal v10 geometry) changes the hierarchy of volumes, while keeping the overall number of levels constant. The volume from whose copy number the side can be derived is no more the 7th (EREG) but the 8th (CALOEC). The numbering scheme is defining the side in the DetId based on this information, and needs to be adapted accordingly.

PR validation:

The Geometry/MTDCommonData test for numbering and position shows that the side is now correctly assigned depending on the CALOEC copy number (and absolute position in the global system of coordinates):

 - /cms:OCMS[0]/cms:CMSE[1]/caloBase:CALO[1]/caloBase:CALOEC[1]/caloBase:CALOECTSFront[1]/caloBase:CALOECFront[1]/etl:EndcapTimingLayer[1]/mtd:Disc1[1]/mtd:Ring1Disc1[1]/mtd:EModule1Disc1[1]/mtd:EModule1Disc1Timingwafer[1]/mtd:EModule1Disc1Timingactive[1]
[MTDDetId::print]  0110 0011 0100 0001 0000 0000 1000 0000
 rawId       : 0x63410080
 bits[0:24]  : 01410080
 Detector        : 6
 SubDetector     : 1
 MTD subdetector : 2
 ETL 
 Side        : 1
 Ring        : 1
 Module      : 1
 Module type : 0
 - /cms:OCMS[0]/cms:CMSE[1]/caloBase:CALO[1]/caloBase:CALOEC[2]/caloBase:CALOECTSFront[1]/caloBase:CALOECFront[1]/etl:EndcapTimingLayer[1]/mtd:Disc1[1]/mtd:Ring1Disc1[1]/mtd:EModule1Disc1[1]/mtd:EModule1Disc1Timingwafer[1]/mtd:EModule1Disc1Timingactive[1]
[MTDDetId::print]  0110 0011 0000 0001 0000 0000 1000 0000
 rawId       : 0x63010080
 bits[0:24]  : 01010080
 Detector        : 6
 SubDetector     : 1
 MTD subdetector : 2
 ETL 
 Side        : 0
 Ring        : 1
 Module      : 1
 Module type : 0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26307/9006

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 1, 2019

please test workflow 27434.0,29034.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33878/console Started: 2019/04/01 15:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26307/33878/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26307/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 2, 2019

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 2, 2019

type bugfix

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 2, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants