New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt ETL numbering scheme to new forward volume hierarchy (scenario D41, HGCal v10) #26307
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26307/9006
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 27434.0,29034.0 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
type bugfix |
+1 |
PR description:
Phase 2 scenario D41 (with HGCal v10 geometry) changes the hierarchy of volumes, while keeping the overall number of levels constant. The volume from whose copy number the side can be derived is no more the 7th (EREG) but the 8th (CALOEC). The numbering scheme is defining the side in the DetId based on this information, and needs to be adapted accordingly.
PR validation:
The Geometry/MTDCommonData test for numbering and position shows that the side is now correctly assigned depending on the CALOEC copy number (and absolute position in the global system of coordinates):