Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Modifier.isChosen() private #26310

Merged
merged 1 commit into from Apr 2, 2019
Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Apr 1, 2019

PR description:

Modifier.isChosen() has been discouraged for a long time, and now that all uses of it have been migrated to Modifier.toModify()/toReplaceWith()`, this PR adds a leading underscore to the method name in order make it more "private".

PR validation:

python -m FWCore.ParameterSet.Config runs, limited matrix runs (barring input file read errors).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26310/9009

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
FWCore/ParameterSet

@smuzaffar, @Dr15Jones, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @wddgit, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33884/console Started: 2019/04/01 17:32

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26310/33884/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+operations

the update of StandardSequences is coherent with the purpose of the PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+1

the move should be at this point transparent

@cmsbuild cmsbuild merged commit 8d2f999 into cms-sw:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants