New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added std namespace to avoid cxxmodule Ib errors #26312
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26312/9012
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: DataFormats/FEDRawData @mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@mommsen may I reiterate the question by @smuzaffar : Do we really need these cout in header file? Should we just remove these? |
This is very old code. I think the proper way would be to split the implementation into a dedicated src file and use proper logging. Maybe @emeschi knows why it has not been done like this. |
+1 following the minimal perturbation approach for the time being |
PR description:
CXXMODULE IBs failed (if module is activated for DataFormats/FEDRawData package ) due to unknow cout. This PR adds the missing header and namespace.
Do we really need these
cout
in header file? Should we just remove these?PR validation:
local compilation works
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: