Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added std namespace to avoid cxxmodule Ib errors #26312

Merged
merged 1 commit into from Apr 3, 2019
Merged

Added std namespace to avoid cxxmodule Ib errors #26312

merged 1 commit into from Apr 3, 2019

Conversation

smuzaffar
Copy link
Contributor

PR description:

CXXMODULE IBs failed (if module is activated for DataFormats/FEDRawData package ) due to unknow cout. This PR adds the missing header and namespace.

Do we really need these cout in header file? Should we just remove these?

PR validation:

local compilation works

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26312/9012

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/FEDRawData

@mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mommsen
Copy link
Contributor

mommsen commented Apr 1, 2019

+1
purely technical.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33888/console Started: 2019/04/01 18:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26312/33888/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar changed the title Added std anemspace to avoid cxxmodule Ib errors Added std namespace to avoid cxxmodule Ib errors Apr 1, 2019
@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

@mommsen may I reiterate the question by @smuzaffar : Do we really need these cout in header file? Should we just remove these?

@mommsen
Copy link
Contributor

mommsen commented Apr 2, 2019

This is very old code. I think the proper way would be to split the implementation into a dedicated src file and use proper logging. Maybe @emeschi knows why it has not been done like this.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2019

+1

following the minimal perturbation approach for the time being

@cmsbuild cmsbuild merged commit b599ef8 into cms-sw:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants