Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup dependency: DataFormats/Provenance does not depend on MessageLogger #26313

Merged
merged 1 commit into from Apr 2, 2019
Merged

cleanup dependency: DataFormats/Provenance does not depend on MessageLogger #26313

merged 1 commit into from Apr 2, 2019

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 1, 2019

PR description:

Cleanup dependency: DataFormats/Provenance does not depend on FWCore/MessageLogger.

PR validation:

Local compilation does not show any build errors

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26313/9013

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33891/console Started: 2019/04/01 22:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/Provenance

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar changed the title cleanup dependency: DataFormats/Provenance does not depend on FWCore/… cleanup dependency: DataFormats/Provenance does not depend on MessageLogger Apr 1, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26313/33891/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+1

@cmsbuild cmsbuild merged commit 8b9a56f into cms-sw:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants