Fix thread safety issue in FEDNumbering

[Dr15Jones]

PR description:

Removed the thread unsafe initialization of static member data. Change to initialize the data either at compile time (via the use of constexpr) or at shared library load time.

PR validation:

The code compiles and a new unit test was added to check the code.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26321/9024

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/FEDRawData

@mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33905/console Started: 2019/04/02 14:35

[cmsbuild]

-1

Tested at: 376d5cb

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26321/33905/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

• Build:

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBufferComponents.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/src/SiStripDetSetVectorFiller.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBuffer.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBufferGenerator.h:5:0,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/src/SiStripFEDBufferGenerator.cc:1:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBufferComponents.h:453:36: error: 'vector' in namespace 'std' does not name a template type
       FEDAPVErrorHeader(const std::vector& apvsGood = std::vector(APVS_PER_FED,true));
                                    ^~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-02-1100/src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBufferComponents.h:453:42: error: expected ',' or '...' before '<' token
       FEDAPVErrorHeader(const std::vector& apvsGood = std::vector(APVS_PER_FED,true));
                                          ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #26321 was updated. @mommsen, @cmsbuild, @perrotta, @emeschi, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33938/console Started: 2019/04/03 16:54

[cmsbuild]

+1
Tested at: 9073dac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26321/33938/summary.html
Additional comment: Compilation Warnings: Yes

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26321/33938/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3139747
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3139549
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26321 9073dac

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences

[mommsen]

+1
Thanks @Dr15Jones for taking care of improving this code!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@Dr15Jones @smuzaffar the reported compilation warning looks real, and I can easily it fix in a separate PR. But it looks to me that the fednum variable is unused regardless of this PR, so why is it popping out only now? The change introduced by this PR is that FEDNumbering has no more private data members.

[Dr15Jones]

@fabiocos I promise to fix the new compilation warning in another pull request. No good guess as to why it only appears now.

[fabiocos]

+1