Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split matching into GSF to track and GSF to Packed, store the first in AOD #26325

Merged
merged 1 commit into from Apr 9, 2019

Conversation

mverzett
Copy link
Contributor

@mverzett mverzett commented Apr 2, 2019

This PR is a bugfix for what observed here

THIS PR HAS NOT BEEN TESTED

@slava77 @perrotta I could not find a suitable runTheMatrix to run on. I would like to have a step up to AOD and a step for miniAOD only. Which incantation should I use?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26325/9028

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

A new Pull Request was created by @mverzett (Mauro Verzetti) for master.

It involves the following packages:

DataFormats/TrackReco
PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers

@cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jainshilpi, @rappoccio, @HeinerTholen, @ahinzmann, @varuns23, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @lgray, @jdolen, @drkovalskyi, @ferencek, @Sam-Harper, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

desc.add<edm::InputTag>("tracks", edm::InputTag("generalTracks"));
desc.add<edm::InputTag>("gsfPreID", edm::InputTag("lowPtGsfElectronSeeds"));
desc.add<edm::InputTag>("gsfTracks", edm::InputTag("lowPtGsfEleGsfTracks"));
descriptions.add("lowPtGsfToTrackLinksDefault", desc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you foresee era-based customization for the cfi? If not, this could be just add("lowPtGsftoTrackLinks", desc)" or "addWithDefaultlabel(desc) and the cfi be dropped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makortel not really, but I cannot foresee the future, therefore I prefer to do this now rather than later.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The code-checks are being triggered in jenkins.

@mverzett
Copy link
Contributor Author

mverzett commented Apr 3, 2019

Update: this PR has been tested in its backport form with the same chain PdmV used when they observed failures. The code runs and produces meaningful results.

Still, would be good to check it in a runTheMatrix integration test here as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26325/9049

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Pull request #26325 was updated. @cmsbuild, @perrotta, @santocch, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Apr 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33946/console Started: 2019/04/03 23:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26325/33946/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@srimanob
Copy link
Contributor

srimanob commented Apr 4, 2019

@mverzett @fabiocos
New PR (#26365) which adds PROD-Like for 2018, where miniaod (w/ and w/o b-parking) are produced separately from RECO.

Workflow with b-Parking in RECO and MINIAOD:
runTheMatrix.py --what standard -l 1304.181 -t 8 --noCaf --wm init
It seems to run fine locally with @mverzett PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #26365

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #26365

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2019

CPU time and event output size increase were measured with both tight WP (standard workflows) and loose WP (bParking) with the TTbar PU wf 11024:

- (tight WP)      added      +0.00%         0.00 ms/ev ->         0.02 ms/ev lowPtGsfToTrackLinks
- (loose WP)      added      +0.00%         0.00 ms/ev ->         0.04 ms/ev lowPtGsfToTrackLinks
- (tight WP)      0.0 ->        53.9         54     NEWO   0.00     recoTracksedmAssociation_lowPtGsfToTrackLinks__RECO.
- (loose WP)      0.0 ->       379.5        380     NEWO   0.01     recoTracksedmAssociation_lowPtGsfToTrackLinks__RECO.

The additional size required by the additional association links is limited for the standard reco workflows (54 B/evt here) and also for the bParking reconstruction workflows (380 B/evt)

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

merge

@santocch there is no analysis-only addition here, please have a look anyway

@srimanob
Copy link
Contributor

srimanob commented Apr 9, 2019

@mverzett
Could you please do back port? The PR for workflows is already back ported to 10_2 (#26400) Thx.

@mverzett mverzett mentioned this pull request Apr 9, 2019
@santocch
Copy link

santocch commented Apr 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants