New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: proton reconstruction, algorithm update #26335
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26335/9048
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: CalibPPS/ESProducers @perrotta, @andrius-k, @kmaeshima, @schneiml, @tocheng, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @slava77, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
please test |
-1 Tested at: baa62b2 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log136.7611 step2 runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log136.8311 step2 runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log136.85 step3 runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log
I found errors in the following addon tests: cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Wed Apr 3 18:30:05 2019-date Wed Apr 3 18:21:58 2019 s - exit: 16640 |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 for #26335 dfa0859
My observations of the differences are in line with #26335 (comment) |
+1 |
@santocch the analysis part is restricted to PhysicsTools/PatAlgos, could you please have a look? This PR is needed for pre4 |
1 similar comment
@santocch the analysis part is restricted to PhysicsTools/PatAlgos, could you please have a look? This PR is needed for pre4 |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR updates the PPS proton reconstruction code with minimal changes to the configuration. It contains several bugfixes and small improvements of the existing code. Mainly, it brings new algorithms:
This PR is essential for the UL re-reco.
PR validation:
Below a comparison test of re-running the full PPS reco chain on
/store/data/Run2016B/DoubleEG/RAW/v2/000/275/371/00000/FE9F0F13-9436-E611-8F39-02163E012B47.root
. Red histograms are obtained with #26305, the blue ones with this PR. The differences are very small. The seemingly big difference in the xi plots is due to different binnings. In the other histograms (where the same binning is used), blue curves are never above the red ones. This is expected since in 2016, the (strip) detectors could not resolve more than 1 local track. Thus the only effect of this PR is the removal of spurious/doubtful local-track combinations.