Move fireworks exception handling to pybind11

[davidlange6]

PR description:

Move fireworks exception handling to pybind11 - remove include from src directory as added bonus

PR validation:

compiles.

[davidlange6]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26342/9054

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33937/console Started: 2019/04/03 16:44

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FWCore/PyDevParameterSet
Fireworks/FWInterface

@cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@makortel, @alja, @wddgit, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: d4156ac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26342/33937/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/MakePyBind11ParameterSets.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/initializePyBind11Module.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/PyBind11ProcessDesc.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/Python11ParameterSet.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/PyBind11ProcessDesc.cc:5:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/poison/FWCore/PyDevParameterSet/src/PyBind11Wrapper.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/src/FWCore/PyDevParameterSet/src/PyBind11ProcessDesc.cc:5:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-03-1100/poison/FWCore/PyDevParameterSet/src/PyBind11Wrapper.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26342/9061

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33943/console Started: 2019/04/03 19:23

[cmsbuild]

Pull request #26342 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please check and sign again.

[cmsbuild]

+1
Tested at: 2cd11b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26342/33943/summary.html

[cmsbuild]

Comparison job queued.

[alja]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26342/33943/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3139747
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3139549
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1