Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small changes in CondCore for PPS proton reco, and serialization … #26350

Merged
merged 1 commit into from Apr 9, 2019

Conversation

wpcarvalho
Copy link
Contributor

…test code for LHCOpticalFunctions

PR description:

This PR includes:

  • Minor changes needed for reading(writing) optical functions data from(into) POOL databases, consumed by the proton reconstruction introduced by the recently merged PR PPS proton reconstruction #25495.

  • A serialization test code for the condition formats LHCOpticalFunctionsSet and LHCOpticalFunctionsCollection introduced in PPS proton reconstruction #25495.

PR validation:

Tests run: just followed https://cms-sw.github.io/PRWorkflow.html.

Informing: @jan-kaspar @malbouis @clemencia @forthommel

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26350/9065

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

A new Pull Request was created by @wpcarvalho (Wagner Carvalho) for master.

It involves the following packages:

CondCore/CTPPSPlugins
CondCore/Utilities
CondFormats/CTPPSReadoutObjects

@ggovi, @cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@tocheng, @forthommel, @jan-kaspar, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@wpcarvalho
Copy link
Contributor Author

I forgot to add that this PR is essential for UL re-reco.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33981/console Started: 2019/04/04 17:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26350/33981/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@pohsun
Copy link

pohsun commented Apr 5, 2019

+1

@wpcarvalho
Copy link
Contributor Author

Hi, still missing a couple of approvals. Target is last open CMSSW_10_6_X release (deadline tomorrow). These small changes are essencial for PPS DB usage in UL reco. Many thanks for reviewing.

@ggovi
Copy link
Contributor

ggovi commented Apr 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@cmsbuild cmsbuild merged commit 2c7e549 into cms-sw:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants