New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small changes in CondCore for PPS proton reco, and serialization … #26350
Conversation
…test code for LHCOpticalFunctions
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26350/9065
|
A new Pull Request was created by @wpcarvalho (Wagner Carvalho) for master. It involves the following packages: CondCore/CTPPSPlugins @ggovi, @cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I forgot to add that this PR is essential for UL re-reco. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Hi, still missing a couple of approvals. Target is last open CMSSW_10_6_X release (deadline tomorrow). These small changes are essencial for PPS DB usage in UL reco. Many thanks for reviewing. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
…test code for LHCOpticalFunctions
PR description:
This PR includes:
Minor changes needed for reading(writing) optical functions data from(into) POOL databases, consumed by the proton reconstruction introduced by the recently merged PR PPS proton reconstruction #25495.
A serialization test code for the condition formats
LHCOpticalFunctionsSet
andLHCOpticalFunctionsCollection
introduced in PPS proton reconstruction #25495.PR validation:
Tests run: just followed https://cms-sw.github.io/PRWorkflow.html.
Informing: @jan-kaspar @malbouis @clemencia @forthommel