DD4hep: Merge Geometry Event Setup Records

[ianna]

PR description:

Use the same geometry records for both the DD and the DD4hep-based geometries.
@Dr15Jones - FYI, it looks like this takes more time:

< Benchmark 'DTGeometryESProducer' took 3117.68 millis
---
> Benchmark 'DTGeometryESProducer' took 2673.57 millis

PR validation:

The tests are run automatically during the PR integration

if this PR is a backport please specify the original PR:

no back port is needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26352/9068

• This PR adds an extra 128KB to repository

• Found files with invalid states:

  • Geometry/Records/interface/MuonGeometryRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/interface/MuonNumberingRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/MuonNumberingRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/MuonGeometryRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/DetectorDescriptionRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/interface/DetectorDescriptionRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/DTGeometryBuilder/plugins/dd4hep/DTGeometryValidate.cc:
    • Added: 1847306
    • Modified: 94b6c1b
    • Deleted: c8f01c3

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
DetectorDescription/Parser
DetectorDescription/RecoGeometry
DetectorDescription/RegressionTest
Geometry/DTGeometryBuilder
Geometry/MuonNumbering
Geometry/Records

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33958/console Started: 2019/04/04 14:15

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26352/9086

• This PR adds an extra 216KB to repository

• Found files with invalid states:

  • Geometry/Records/interface/MuonGeometryRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/interface/MuonNumberingRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/MuonNumberingRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/MuonGeometryRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/src/DetectorDescriptionRcd.cc:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/Records/interface/DetectorDescriptionRcd.h:
    • Added: 37db9fb
    • Deleted: 000305c
  • Geometry/DTGeometryBuilder/plugins/dd4hep/DTGeometryValidate.cc:
    • Added: 1847306
    • Modified: 94b6c1b
    • Deleted: c8f01c3

[cmsbuild]

Pull request #26352 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26352/9145

• This PR adds an extra 52KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34062/console Started: 2019/04/08 22:17

[cmsbuild]

Pull request #26352 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[cmsbuild]

+1
Tested at: 904c606
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26352/34062/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
904c606
418ada8
83bf6e2
9c382f9
265b2c5
fb758d2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26352/34062/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26352/34062/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26352/34062/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140297
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1