Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variable from SiPixelFedFillerWordEventNumber #26366

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This was causing a compiler warning.

PR validation:

The code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26366/9104

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibTracker/SiPixelTools

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33994/console Started: 2019/04/05 13:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

-1

Tested at: 6d0e7dd

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fbf3e47
f596ddc
c324750
b0eaa5a
c9a10d7
0b320c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/33994/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/33994/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/33994/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fbf3e47
f596ddc
c324750
b0eaa5a
c9a10d7
0b320c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/33994/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/33994/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34004/console Started: 2019/04/05 17:11

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34016/console Started: 2019/04/05 22:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26366/34016/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2019

merge

@tocheng this is a trivial compiler fix, please check and sign it for future reference, or comment in case

@cmsbuild cmsbuild merged commit b7e1a6d into cms-sw:master Apr 6, 2019
@pohsun
Copy link

pohsun commented Apr 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@Dr15Jones Dr15Jones deleted the fixSiPixelFedFillerWordEventNumber branch April 22, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants