New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New slopes for S9S1filter #26382
New slopes for S9S1filter #26382
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26382/9131
|
A new Pull Request was created by @toropin for master. It involves the following packages: RecoLocalCalo/HcalRecProducers @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@toropin : jenkins tests show no differences at all in Run2 outputs. |
Yes, we are looking for a level of ~10-4. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is devoted to the definition of new slopes for the limit lines in the planes 'S9S1 vs log(ELong)' for HF S9S1 filter. The slopes are different for the different HF Ieta values.
All parameters of S9S1(S8S1) filter were defined in ~2010 with lower energy of colliding beams and lower luminosity. It is the isolation filter and with much higher luminosity we have now the isolation
parameters could be different. See report in ref. 1 from slide 29.
On slide 30 presented distributions S9S1 vs log(ELong) for different Ieta. There are 2 inclined lines in each plot for Ieta 30 - 34. The lower lines correspond to the current slope parameters, the upper
lines correspond to the proposed new parameters.
The goal of this work is to reduce populations of hits above the old slope lines. These hits could be responsible for fake jets originated in HF.
On slides 34 and 35 presented the examples of HF hits which could be marked by S9S1 filter if slopes would be increased. In the lower lines in the captions to the pictures you can see S9S1 as the value calculated by filter, S9S1cut is the limit defined with old slopes, S9S1max is the new limit defined with changed slopes.
References:
PR validation:
In this PR only python file HFPhase1Reconstructor_cfi.py was modified. S9S1 slopes were multiplied by vector of constants to increase their values. These modifications are for Run 2 data. This file is for Run 2 reconstruction and this PR cannot affect data of Run 1.
The performance of reconstruction with the new slopes was tested. On the Screenshot of EventDisplay (FireWorks) below presented HF hit (signal in Long fiber) which was not marked by S9S1 filter. For these pictures threshold = 40 GeV was applied.
On the picture below presented the same hit marked by S9S1 filter after slopes were increased. In the column 'flags' uppermost hit has flag value 1048577. It means it has bit0 = 1 which corresponds to the S9S1 filter decision.