Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecesary include from EcalLaserDbService #26387

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The header file tbb/concurrent_hash_map.h was unnecessary for this class.
In addition, that header does not presently compile with gcc9.

PR validation:

After change the code compiles using CMSSW_10_6_DEVEL_X_2019-04-07-2300 with architecture slc7_amd64_gcc900.

In addition, concurrent_hash_map.h does not presently compile with gcc9.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26387/9140

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibCalorimetry/EcalLaserCorrection

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34057/console Started: 2019/04/08 18:21

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34061/console Started: 2019/04/08 21:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26387/34061/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@pohsun
Copy link

pohsun commented Apr 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@cmsbuild cmsbuild merged commit d74d158 into cms-sw:master Apr 9, 2019
@Dr15Jones Dr15Jones deleted the removeIncludeTBB branch April 22, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants