New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecesary include from EcalLaserDbService #26387
Conversation
In addition, concurrent_hash_map.h does not presently compile with gcc9.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26387/9140
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CalibCalorimetry/EcalLaserCorrection @cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The header file tbb/concurrent_hash_map.h was unnecessary for this class.
In addition, that header does not presently compile with gcc9.
PR validation:
After change the code compiles using CMSSW_10_6_DEVEL_X_2019-04-07-2300 with architecture slc7_amd64_gcc900.