PPS: proton reco finalisation before UL re-reco #26394

jan-kaspar · 2019-04-09T06:54:56Z

PR description:

This PR contains several finalisation changes for PPS proton reconstruction before the UL re-reco:

c5c4e47: removes the hardcoded IOV as promised in PPS proton reconstruction #25495
ff4097a: switches to CondDB as the default source of LHCInfo and optical functions.
9d56bb7: cherry-pick of @tocheng 's commit 3aececc to include optical functions in auto GT.
bfe7a0a: PPS proton-reconstruction module does nothing if input empty. This prevents loading non-existing conditions in workflows without PPS proton data.

cmsbuild · 2019-04-09T06:55:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-09T07:01:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26394/9150

This PR adds an extra 12KB to repository

cmsbuild · 2019-04-09T07:02:00Z

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jan-kaspar · 2019-04-09T07:02:52Z

FYI @fabferro @forthommel

slava77 · 2019-04-09T07:54:05Z

@cmsbuild please test

cmsbuild · 2019-04-09T07:54:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34067/console Started: 2019/04/09 09:55

cmsbuild · 2019-04-09T09:00:39Z

-1

Tested at: ff4097a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26394/34067/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

27434.0 step3

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:48:31 2019-date Tue Apr 9 10:39:28 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:49:30 2019-date Tue Apr 9 10:39:32 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:51:45 2019-date Tue Apr 9 10:39:35 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:54:39 2019-date Tue Apr 9 10:39:39 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:51:51 2019-date Tue Apr 9 10:39:45 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:50:35 2019-date Tue Apr 9 10:39:49 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:52:35 2019-date Tue Apr 9 10:39:52 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:51:04 2019-date Tue Apr 9 10:39:56 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:54:07 2019-date Tue Apr 9 10:40:19 2019 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Tue Apr 9 10:53:21 2019-date Tue Apr 9 10:46:58 2019 s - exit: 16640

cmsbuild · 2019-04-09T09:00:43Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

jan-kaspar · 2019-04-09T09:07:11Z

I have quickly checked some of the failures - the reason is missing ESSource for CTPPSOpticsRcd. This is currently expected and will be solved by #26350 (and the following DB upload).

tocheng · 2019-04-12T15:10:05Z

@cmsbuild please test with #26415

cmsbuild · 2019-04-17T17:00:42Z

+1
Tested at: bfe7a0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26394/34252/summary.html

cmsbuild · 2019-04-17T17:00:48Z

Comparison job queued.

cmsbuild · 2019-04-17T19:08:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26394/34252/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 583 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3142783
DQMHistoTests: Total failures: 3049
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3139537
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

slava77 · 2019-04-17T20:06:22Z

+1

for #26394 bfe7a0a

code changes are somewhat in line with the PR description and then align with the follow up review and discussion
- please update the PR description
jenkins tests pass and comparisons with the baseline show differences in somewhat expected places
- there are quite a few changes in JET-related quantities related to the GT changes https://cms-conddb-prod.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v4/106X_dataRun2_v8
- 2017F workflow 136.8311 shows that ctppsProtons reconstruction is now running (GT change includes an extension to the optical function range)
- 2018A wf 136.85 shows some changes in the ctppsDiamondRecHits reco and CTPPS/TimingDiamond DQM plots; apparently in line with the GT changes as well
- the change that actually triggered a reco signature is only in RecoCTPPS/ProtonReconstruction/plugins/CTPPSProtonProducer.cc : this change is technical, to skip the reco algorithm calls for empty inputs.

tocheng · 2019-04-17T20:45:34Z

+1

cmsbuild · 2019-04-17T20:46:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-04-17T20:49:05Z

+1

jan-kaspar · 2019-04-18T08:17:23Z

code changes are somewhat in line with the PR description and then align with the follow up review and discussion

please update the PR description

Description updated.

fabiocos · 2019-04-18T09:43:40Z

@jan-kaspar @tocheng @slava77 unfortunately this PR is causing an issue in the IB:

----- Begin Fatal Exception 18-Apr-2019 11:23:17 CEST-----------------------
An exception of category 'ProtonReconstructionAlgorithm' occurred while
   [0] Processing  Event run: 314276 lumi: 161 event: 120565217 stream: 3
   [1] Running path 'Flag_trkPOG_logErrorTooManyClusters'
   [2] Prefetching for module LogErrorEventFilter/'logErrorTooManyClusters'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Calling method for module CTPPSProtonProducer/'ctppsProtons'
Exception Message:
Optics data not available for RP 2006974464, i.e. subDet=3 arm=1 station=2 rp=4.
----- End Fatal Exception -------------------------------------------------

in wf 136.8562 , the test for the high beta star runs. From the message it looks like the optics info for this run is not properly loaded and triggers the exception in

https://cmssdt.cern.ch/lxr/source/RecoCTPPS/ProtonReconstruction/src/ProtonReconstructionAlgorithm.cc#0151

Is this problem expected from the provided setup?

jan-kaspar · 2019-04-18T09:54:05Z

@fabiocos Yes, this is expected. The optics currently uploaded to DB covers the full 2018 without excluding the special runs (high beta). These runs use different RPs than the low beta runs, that's why the message. We are aware of this problem and the new optics payloads, currently under test, exclude the two special-run periods:
https://github.com/CTPPS/cmssw/blob/proton_reco_step2/CalibPPS/ESProducers/python/ctppsOpticalFunctions_cff.py#L85
For the special-run periods, we agreed with @wpcarvalho to upload null payloads, which will inhibit the proton reconstruction module, thus avoid the error. We plan to upload the new optics payloads ~mid next week.

fabiocos · 2019-04-18T09:55:41Z

@jan-kaspar ok, so given the limited scope of these tests, I will not consider it a show-stopper for pre4, under the assumption it will be fixed for pre5

jan-kaspar · 2019-04-18T10:00:07Z

OK

cmsbuild added this to the CMSSW_10_6_X milestone Apr 9, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Apr 9, 2019

jan-kaspar mentioned this pull request Apr 9, 2019

Next items for proton reconstruction CTPPS/cmssw#37

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 9, 2019

tocheng mentioned this pull request Apr 12, 2019

Update Data/MC GTs in 106X #26415

Merged

cmsbuild added comparison-pending and removed comparison-notrun tests-rejected labels Apr 12, 2019

cmsbuild added the tests-started label Apr 17, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 17, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 17, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 17, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Apr 17, 2019

cmsbuild added orp-approved and removed orp-pending labels Apr 17, 2019

cmsbuild merged commit 88a88db into cms-sw:master Apr 17, 2019

tocheng mentioned this pull request Apr 18, 2019

Removing hard-coded eta dependency from PFEnergyCalibration.cc #25883

Merged

slava77 mentioned this pull request Apr 18, 2019

add/update highBetaStar 2018 workflows with a physics data run #24795

Closed

jan-kaspar deleted the proton_reco_step2_final branch December 12, 2019 12:45

silviodonato mentioned this pull request Dec 1, 2020

No "LHCInfoRcd" record found in the EventSetup.n (CTPPSProtonProducer/'ctppsProtons') #32340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPS: proton reco finalisation before UL re-reco #26394

PPS: proton reco finalisation before UL re-reco #26394

jan-kaspar commented Apr 9, 2019 •

edited

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

jan-kaspar commented Apr 9, 2019

slava77 commented Apr 9, 2019

cmsbuild commented Apr 9, 2019 •

edited

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

jan-kaspar commented Apr 9, 2019

tocheng commented Apr 12, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

slava77 commented Apr 17, 2019 •

edited

tocheng commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

fabiocos commented Apr 17, 2019

jan-kaspar commented Apr 18, 2019

fabiocos commented Apr 18, 2019

jan-kaspar commented Apr 18, 2019

fabiocos commented Apr 18, 2019

jan-kaspar commented Apr 18, 2019

PPS: proton reco finalisation before UL re-reco #26394

PPS: proton reco finalisation before UL re-reco #26394

Conversation

jan-kaspar commented Apr 9, 2019 • edited

PR description:

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

jan-kaspar commented Apr 9, 2019

slava77 commented Apr 9, 2019

cmsbuild commented Apr 9, 2019 • edited

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

jan-kaspar commented Apr 9, 2019

tocheng commented Apr 12, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

slava77 commented Apr 17, 2019 • edited

tocheng commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

fabiocos commented Apr 17, 2019

jan-kaspar commented Apr 18, 2019

fabiocos commented Apr 18, 2019

jan-kaspar commented Apr 18, 2019

fabiocos commented Apr 18, 2019

jan-kaspar commented Apr 18, 2019

jan-kaspar commented Apr 9, 2019 •

edited

cmsbuild commented Apr 9, 2019 •

edited

slava77 commented Apr 17, 2019 •

edited