Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrange migration for python3 #26412

Merged
merged 1 commit into from Apr 11, 2019
Merged

xrange migration for python3 #26412

merged 1 commit into from Apr 11, 2019

Conversation

davidlange6
Copy link
Contributor

@davidlange6 davidlange6 commented Apr 9, 2019

at least one unit test in my python3 fwk test fails due to the use of xrange (now range in python3). Migrate using

futurize -f libfuturize.fixes.fix_xrange_with_import -w --no-diffs -n .

(the dqm packages)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26412/9181

  • This PR adds an extra 468KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DQM/Integration
DQMServices/Components
DQMServices/FileIO
DQMServices/FwkIO
Validation/Performance
Validation/RecoTau
Validation/RecoTrack
Validation/RecoVertex
Validation/Tools

@smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @batinkov, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @thomreis, @wmtford, @mtosi, @ebrondol, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34097/console Started: 2019/04/09 21:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26412/34097/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@Dr15Jones
Copy link
Contributor

+1
Validation/Performance

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2006681 into cms-sw:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants