Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data/MC GTs in 106X #26415

Merged
merged 19 commits into from Apr 18, 2019
Merged

Update Data/MC GTs in 106X #26415

merged 19 commits into from Apr 18, 2019

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Apr 9, 2019

PR description:

The PR is to update the DATA/MC GTs in autoCond

Run-1/Run-2 Data

Difference between GTs in PR and GTs in master branch is due to JEC/JER update (for 2018 data), LHCinfo, PPS geometry fix, PF calibration at HLT and pixel 1D/2D templates plus GenErr Lorentz angle for 2017 data
Diff
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v8/106X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v6/106X_dataRun2_relval_v1

Prompt-like Data

Difference between GTs in PR and GTs in master branch is due to LHCinfo, LHC optical function, PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HEfail_4/106X_dataRun2_PromptLike_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_v4/106X_dataRun2_PromptLike_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HI_v4/106X_dataRun2_PromptLike_HI_v1

HLT

Difference between GTs in PR and GTs in master branch is due to PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/101X_dataRun2_HLT_frozen_v9/101X_dataRun2_HLT_frozen_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_HLT_relval_v8/103X_dataRun2_HLT_relval_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_HLT_relval_HI_v4/103X_dataRun2_HLT_relval_HI_v3

Run-1 MC

No difference between GTs in PR and GTs in master branch.
Diff
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun1_design_v1/105X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun1_realistic_v1/105X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun1_HeavyIon_v1/105X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun1_pA_v1/105X_mcRun1_pA_v1

2015 MC

No difference between GTs in PR and GTs in master branch except difference in 2015 simulation due to HLT PF calibration
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_startup_v2/105X_mcRun2_startup_v1
Diff
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_l1stage1_v2/105X_mcRun2_asymptotic_l1stage1_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_pA_v2/105X_mcRun2_pA_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_HeavyIon_v2/105X_mcRun2_HeavyIon_v2

2016 MC

No difference in 2016 simulation as the latest JEC/JER is already in
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_v3/105X_mcRun2_asymptotic_v4
ECAL ideal condition update
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_design_v3/105X_mcRun2_design_v3

Difference in cosmic GTs is due to PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2cosmics_startup_deco_v2/105X_mcRun2cosmics_startup_deco_v4

2017 MC

Differences are due to JEC/JER update and PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017_realistic_v3/106X_mc2017_realistic_v1
ECAL ideal condition update and PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017_design_IdealBS_v4/106X_mc2017_design_IdealBS_v2

Cosmic GTs change due to PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017cosmics_realistic_deco_v2/106X_mc2017cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017cosmics_realistic_peak_v2/106X_mc2017cosmics_realistic_peak_v1

2018 MC

Differences are due to JEC/JER update+Tracker mis-alignment scenario+PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_v4/106X_upgrade2018_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HEfail_v4/106X_upgrade2018_realistic_HEfail_v1
Differences are due to Tracker mis-alignment scenario
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018cosmics_realistic_deco_v3/106X_upgrade2018cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018cosmics_realistic_peak_v3/106X_upgrade2018cosmics_realistic_peak_v1

ECAL ideal condition update+PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_design_v3/106X_upgrade2018_design_v1

Heavy Ion GTs changes due to PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HI_v2/106X_upgrade2018_realistic_HI_v1

Run-3 MC

Differences are due to Pixel quality for Run-3+HCAL eMap and L1 object update+PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_postLS2_design_v4/106X_postLS2_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_postLS2_realistic_v4/106X_postLS2_realistic_v1

Phase-2 MC

Differences are due to Phase-2 tracker DTC eMap+PF calibration at HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2023_realistic_v2/105X_upgrade2023_realistic_v5

PR validation:

The updates are motivated by

1)JEC/JER update : see JEC/JER twiki
hn announcement for JEC/JER in data for 2016-2018
2)Tracker mis-alignment scenario for 2018 : see hn announcement
3) ECAL design condition updates for 2016-2018 : see hn announcement
4) Pixel quality for Run-3 : see hn announcement
5) HCAL eMap and L1 object update for Run-3 (and MWGR analysis) : see hn announcement
6) Phase-2 tracker DTC eMap : see hn announcement
7) PF calibration PR #25883
8) LHC info for 2016 to 2018
9) 2017 pixel 1D/2D templates plus GenErr Lorentz angle for 2017 data : see hn announcement
10) PPS geometry fix in #26316

Not include PPS optical function to support proton reconstruction
so this PR can be decoupled from #26394 (and #26350 )

runTheMatrix test is performed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26415/9184

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Apr 9, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34106/console Started: 2019/04/10 01:33

@tocheng
Copy link
Contributor Author

tocheng commented Apr 9, 2019

@cmsbuild please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26415/9185

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Pull request #26415 was updated. @cmsbuild, @pohsun, @franzoni, @tocheng can you please check and sign again.

@tocheng
Copy link
Contributor Author

tocheng commented Apr 10, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34107/console Started: 2019/04/10 02:07

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26415/9347

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #26415 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

@tocheng tocheng force-pushed the 106X_autoCondMC branch 2 times, most recently from 91a0d83 to c12f560 Compare April 18, 2019 03:20
@tocheng
Copy link
Contributor Author

tocheng commented Apr 18, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34269/console Started: 2019/04/18 05:29

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26415/34269/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26415/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4310 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 12817
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3129769
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Apr 18, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants