New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate away from commands in das utility #26418
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26418/9188
|
i think my test doesn't actually test my change... investigating more
… On Apr 10, 2019, at 8:47 AM, cmsbuild ***@***.***> wrote:
The code-checks are being triggered in jenkins.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Utilities/General @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26418/9190
|
Pull request #26418 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
please test
… On Apr 10, 2019, at 12:00 PM, cmsbuild ***@***.***> wrote:
Pull request #26418 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
The python module 'commands' is deprecated in python2.7 and removed from python3. Replace it
PR validation:
checked unit tests using das utility work ok