add bool method to cms.Bool #26427
add bool method to cms.Bool #26427
Conversation
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26427/9200
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Could you add a unit test the show that it works? |
|
Unit tests for comparison operations in Types.py need to be strengthened in general I'm getting to it slowly.
… On Apr 10, 2019, at 4:09 PM, Chris Jones ***@***.***> wrote:
Could you add a unit test the show that it works?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
|
So the test is actually there.. but run explicitly with python2.. I can add a parallel python3 check (but after this PR goes in so that it passes...)
… On Apr 10, 2019, at 5:20 PM, Chris Jones ***@***.***> wrote:
Unit tests for comparison operations in Types.py need to be strengthened in general I'm getting to it slowly.
I'm fine with just adding this one test :).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
So the reason this didn't get run is you are not running the unit tests using python2 and python3? Can we come up with a way to do so? The tests are just executed now from FWCore/ParameterSet/test/runPythonTests.sh. That could either be extended to run python2 and python3 or a similar versions of that script to be move to the package that gives python3 support. |
|
the unit test is a shell script that calls 'python' explicitly. Its easy to modify to run both (but now your correct question is how to find the N other cases like this...)
… On Apr 10, 2019, at 5:40 PM, Chris Jones ***@***.***> wrote:
So the reason this didn't get run is you are not running the unit tests using python2 and python3? Can we come up with a way to do so? The tests are just executed now from FWCore/ParameterSet/test/runPythonTests.sh. That could either be extended to run python2 and python3 or a similar versions of that script to be move to the package that gives python3 support.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
needed by Python3 so that if cms.Bool(False): evaluates to False