Run3-sim32 Clean up the prints and make it conform clang

[bsunanda]

PR description:

Modify the debug and conform to clang standard

PR validation:

Standard matrix runs properly

if this PR is a backport please specify the original PR:

Not to be back ported

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26447/9251

• This PR adds an extra 156KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34178/console Started: 2019/04/12 16:23

[cmsbuild]

-1

Tested at: 1a913cb

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26447/34178/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/HFChamberSD.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/FiberSD.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/HFShowerG4Hit.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/CastorShowerLibraryMaker.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/CastorShowerLibraryMaker.cc: In member function 'virtual void CastorShowerLibraryMaker::update(const BeginOfEvent*)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/CastorShowerLibraryMaker.cc:294:27: error: 'LogInfo' is not a member of 'edm'
         if (!accept) edm::LogInfo("CastorShowerLibraryMaker") << "Event not accepted for ebin="
                           ^~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/CastorShowerLibraryMaker.cc: In member function 'virtual void CastorShowerLibraryMaker::update(const EndOfEvent*)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-11-2300/src/SimG4CMS/ShowerLibraryProducer/src/CastorShowerLibraryMaker.cc:438:11: error: 'LogInfo' is not a member of 'edm'
      edm::LogInfo("CastorShowerLibraryMaker") << "No valid primary particle found. Skipping event" << std::endl;


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26447/9252

• This PR adds an extra 164KB to repository

[cmsbuild]

Pull request #26447 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34181/console Started: 2019/04/12 18:01

[cmsbuild]

+1
Tested at: f2a7a23
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26447/34181/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26447/34181/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140297
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1